#8772 NORM Not Tri: fix: journal entry creation error in chat for uri-list

[Zarro Boogs per Child]

#8772: fix: journal entry creation error in chat for uri-list
---------------------------+------------------------------------------------
 Reporter:  kevix          |         Owner:  morgs      
     Type:  defect         |        Status:  new        
 Priority:  normal         |     Milestone:  Not Triaged
Component:  chat-activity  |       Version:             
 Keywords:                 |   Next_action:  never set  
 Verified:  0              |     Blockedby:             
 Blocking:                 |  
---------------------------+------------------------------------------------
 I got my XO from the first G1G1. Soon after I joined an small chat server
 community and chatted alot. During that time, we used the Chat activity
 that
 came with the XO. Soon after we found the scroll bug and eventually
 upgraded to
 a newer version. At that time we used the feature to select a urL in the
 chat
 window to open a url that someone else had given and used that to paste
 the URL
 in a browse activity. Most of the members stayed with build 656, while I
 and
 others upgraded to help with the XO testing process. At some point after
 upgrades to the 70x builds, I upgraded my Chat activity and found the URL
 selection menu gone and, at somepoint, realized that the intent was to
 create a
 journal entry that could be clicked to start the Browse activity with the
 requested page. But it did not work. For some reason, no one in my group
 reported this and as far as I can tell, no one reported this exact bug. As
 the
 second G1G1 is approaching, I thought I'd take my minor programming skills
 and
 attempt to investigate the issue. I first compared the Browse Activity
 journal
 entry to the Chat 'url' journal entry. That lead to me noticing the 'uri-
 list'
 mime type associated to the Chat 'url' entry. I thought that the Browse
 activity was not 'opening' this correctly. This turned out to not be the
 case.
 So next I looked at the Chat activity and found the '_Show_via_journal'
 function by searching for 'uri'. I looked at this and thought it looked ok
 but
 noticed that it didn't work. So I read on the wiki about the DS commands
 to
 write a file. There I saw that the wiki page used a path containing
 'instance'
 vs. the '_Show_via_journal' using 'tmp'. I thought this odd. So I
 substituted
 'tmp' for 'instance'. This fixed the issue. The wiki page also used
 'set_file_path' vs 'file_path' that was used in the function. I would
 guess
 that the 'set_file_path' is more correct as it seems closer to being
 object
 oriented. I also read about the uri-list format and noticed that there
 should
 be a file containing a list of URIs, but the datastore did not have 2
 entries
 for the uri-list, it only had one -- the metadata file, the data file was
 missing. That confirmed by assumption that something was missing.

 Conclusion:

 Chat Activity in File pippy_app.py in _show_via_journal

 1) substitute 'instance' for 'tmp'

 2) sustitute jobject.set_file_path(file_path) for jobject.file_path =
 file_path

 Problems:

 1) when you exit the browse activity, it does not properly save

 2) the Firefox activity does not handle uri-list mime types, only the
 browse activity

 Info:

 build 766

-- 
Ticket URL: <http://dev.laptop.org/ticket/8772>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system