#6800 NORM Update.: Journal window should be mirrored in RTL locales

[Zarro Boogs per Child]

#6800: Journal window should be mirrored in RTL locales
-------------------------------+--------------------------------------------
  Reporter:  khaled            |       Owner:  tomeu   
      Type:  defect            |      Status:  new     
  Priority:  normal            |   Milestone:  Update.2
 Component:  journal-activity  |     Version:          
Resolution:                    |    Keywords:          
  Verified:  0                 |    Blocking:  6808    
 Blockedby:                    |  
-------------------------------+--------------------------------------------

Comment(by tomeu):

 Sorry, better formatted review:

 {{{
 +rtl = (gtk.widget_get_default_direction() == gtk.TEXT_DIR_RTL)
 +
 +# for description and tag boxes
 +if rtl:
 +   xalign = hippo.ALIGNMENT_END
 +else:
 +   xalign = hippo.ALIGNMENT_START
 }}}

 I don't think it's worth to define these values at the module level, I'd
 prefer if the actual gtk API was used instead. For example:

 {{{
 +        if gtk.widget_get_default_direction() == gtk.TEXT_DIR_RTL:
 +            self._frame.reverse()
 }}}

 and


 {{{
          vbox.append(hippo.CanvasText(text=_('Description:'),
 -                                     xalign=hippo.ALIGNMENT_START,
 font_desc=style.FONT_NORMAL.get_pango_desc()))
 +        if gtk.widget_get_default_direction() == gtk.TEXT_DIR_RTL:
 +            vbox.props.xalign = hippo.ALIGNMENT_END
 +        else:
 +            vbox.props.xalign = hippo.ALIGNMENT_START
 }}}

-- 
Ticket URL: <http://dev.laptop.org/ticket/6800#comment:3>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system