#6962 NORM Never A: In Sugar-jhbuild, Browse fails to start downloads

[Zarro Boogs per Child]

#6962: In Sugar-jhbuild, Browse fails to start downloads
------------------------------+---------------------------------------------
  Reporter:  HoboPrimate      |       Owner:  erikos        
      Type:  defect           |      Status:  new           
  Priority:  normal           |   Milestone:  Never Assigned
 Component:  browse-activity  |     Version:                
Resolution:                   |    Keywords:  sugar-jhbuild 
  Verified:  0                |    Blocking:                
 Blockedby:                   |  
------------------------------+---------------------------------------------

Comment(by DanKrejsa):

 Replying to [ticket:6962 HoboPrimate]:
 > On a up-to-date sugar-jhbuild in Hardy Heron, Browse doesnt start
 downloads. Attaching its log.
 The attached change in web-activity/downloadmanager.py fix a
 problem causing Browse downloads to fail with an exception in
 onProgressChange64() due to _create_journal_object() having failed
 to be called earlier from onStateChange() when state_flags contained
 the bit STATE_START, but also other bits as corresponding to
 State Type Flags from nsIWebProgressListener.idl.

 I'm pretty confident about the changes in onStateChange(), but
 the change (eliminating a trailing '"' character) in the
 components.registrar.registerFactory() calls are fairly gratuitous,
 and should be checked by someone who is familiar with that API.

 One other issue is that nsIWebProgressListener.idl suggests that
 onStateChange() with STATE_STOP may be called twice for 'document
 requests'.  I haven't seen a problem with that, but the patched
 code might be vulnerable to it.

-- 
Ticket URL: <http://dev.laptop.org/ticket/6962#comment:2>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system