#7292 BLOC Never A: Suspend failing with testing/master branch kernels.

[Zarro Boogs per Child]

#7292: Suspend failing with testing/master branch kernels.
----------------------+-----------------------------------------------------
  Reporter:  cjb      |       Owner:  dilinger      
      Type:  defect   |      Status:  new           
  Priority:  blocker  |   Milestone:  Never Assigned
 Component:  kernel   |     Version:  olpc-3        
Resolution:           |    Keywords:                
  Verified:  0        |    Blocking:                
 Blockedby:           |  
----------------------+-----------------------------------------------------

Comment(by cjb):

 The polarity on the test of olpc_ec_cmd()'s return value is incorrect.
 The stable branch does:

 {{{
 ret = olpc_fixup_sleep();
 if (ret)
         goto fail;
 }}}

 The master/testing branches do:

 {{{
 ret = olpc_fixup_sleep();
 if (!ret)
         goto fail;
 }}}

 The commit that introduced this behavior to master is
 http://dev.laptop.org/git?p=olpc-2.6;a=commitdiff;h=09ac55a001d183f448a6bb8596be4164ab625e6e.

 The commit that introduced the correct behavior to stable is
 http://dev.laptop.org/git?p=olpc-2.6;a=commitdiff;h=f3687aa7e09fd653c594ddbb4b9b3243739b6ddd.

 I don't understand why the patches are different.  I propose committing
 s/!ret/ret/.

-- 
Ticket URL: <http://dev.laptop.org/ticket/7292#comment:5>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system