#5549 HIGH Update.: In rotated mode, game keys retain original orientation

[Zarro Boogs per Child]

#5549: In rotated mode, game keys retain original orientation
------------------------------+---------------------------------------------
  Reporter:  blahedo          |       Owner:  erikg           
      Type:  defect           |      Status:  new             
  Priority:  high             |   Milestone:  Update.2 (8.2.0)
 Component:  x window system  |     Version:  Build 650       
Resolution:                   |    Keywords:                  
  Verified:  0                |    Blocking:                  
 Blockedby:                   |  
------------------------------+---------------------------------------------

Comment(by tomeu):

 Replying to [comment:13 erikg]:
 > Replying to [comment:10 tomeu]:
 >
 > > {{{
 > > +            import errno
 > > }}}
 > >
 > > imports should go at the top of the file
 >
 > I understand that there is a style guide to be followed, but why should
 we categorically import this module if it's only used in an unlikely error
 condition?  My understanding is that Python isn't smart enough to just-in-
 time load library dependencies, so we waste memory by categorically
 importing.

 Would be good to have all the rationale behind the style guide, but I
 don't know where we could get that info. I understand that our guidelines
 are based on some document from the python community? Perhaps Guido
 himself?

 In my opinion, imports at the top helps with understanding which deps a
 module has, and to easily detect "bad smells" related to that. Regarding
 memory saving, I bet that same module has been already imported some dozen
 of times before your code is executed.

-- 
Ticket URL: <http://dev.laptop.org/ticket/5549#comment:16>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system