#7248 NORM 8.2.0 (: Speaker device has inconsistent behavior

[Zarro Boogs per Child]

#7248: Speaker device has inconsistent behavior
-----------------------------+----------------------------------------------
   Reporter:  Eben           |       Owner:  mtd                              
       Type:  defect         |      Status:  reopened                         
   Priority:  normal         |   Milestone:  8.2.0 (was Update.2)             
  Component:  sugar          |     Version:  Development build as of this date
 Resolution:                 |    Keywords:  8.2.0:+ r+                       
Next_action:  test in build  |    Verified:  0                                
  Blockedby:                 |    Blocking:  7381, 7420                       
-----------------------------+----------------------------------------------

Comment(by mtd):

 It's the same issue as #4208 - you can either have the icon be too full
 (current case) or too empty :).  Here's the patch to make it too empty:

 {{{
 diff --git a/src/view/devices/speaker.py b/src/view/devices/speaker.py
 index f785940..df4995c 100644
 --- a/src/view/devices/speaker.py
 +++ b/src/view/devices/speaker.py
 @@ -61,7 +61,7 @@ class DeviceView(TrayIcon):
              xo_color = XoColor('%s,%s' % (style.COLOR_WHITE.get_svg(),
                                            style.COLOR_WHITE.get_svg()))

 -        self.icon.props.icon_name = get_icon_state(name, current_level,
 step=1)
 +        self.icon.props.icon_name = get_icon_state(name, current_level,
 step=-1)
          self.icon.props.xo_color = xo_color

      def __expose_event_cb(self, *args):
 }}}

 Shall I apply it (and add a test case to this ticket)?

-- 
Ticket URL: <http://dev.laptop.org/ticket/7248#comment:28>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system