#7554 NORM 8.2.0 (: sugar.hardware.nmclient.Device() instances' get_colors() method should never raise()

[Zarro Boogs per Child]

#7554: sugar.hardware.nmclient.Device() instances' get_colors() method should
never raise()
----------------------+-----------------------------------------------------
   Reporter:  mtd     |       Owner:  mtd                 
       Type:  defect  |      Status:  new                 
   Priority:  normal  |   Milestone:  8.2.0 (was Update.2)
  Component:  sugar   |     Version:  Git as of bug date  
 Resolution:          |    Keywords:  8.2.0:+             
Next_action:  design  |    Verified:  0                   
  Blockedby:          |    Blocking:                      
----------------------+-----------------------------------------------------

Comment(by mtd):

 Replying to [comment:3 marco]:
 > Replying to [comment:2 mtd]:
 > > That's what the existing code does, though.
 >
 > Hmm I'm confused. The current code just traceback in the case it cannot
 return a color, right?

 I'm sorry marco - I thought you were replying to a different bug ( #7556
 ).  Of course you're right.  So would you be happy with an exception?  I
 think returning None is a bit too mysterious - in my recent experience
 with 6554, current code doesn't like getting None any more than it would
 an exception, and I think - as both options risk a failure - it would be
 better to fail fast.

 It's a tiny change, though, so just say the word and I'll do whichever.

-- 
Ticket URL: <http://dev.laptop.org/ticket/7554#comment:4>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system