#7434 BLOC 8.2.0 (: Control panel UI for power management.

Zarro Boogs per Child bugtracker at laptop.org
Tue Jul 8 05:15:58 EDT 2008


#7434: Control panel UI for power management.
----------------------------+-----------------------------------------------
   Reporter:  cjb           |       Owner:  erikos              
       Type:  enhancement   |      Status:  new                 
   Priority:  blocker       |   Milestone:  8.2.0 (was Update.2)
  Component:  sugar         |     Version:  Update.1            
 Resolution:                |    Keywords:  r+                  
Next_action:  add to build  |    Verified:  0                   
  Blockedby:                |    Blocking:  7380, 7384          
----------------------------+-----------------------------------------------
Changes (by erikos):

  * keywords:  review? => r+
  * next_action:  communicate => add to build


Comment:

 model/power.py

  - If the dbus call in the methods set_*_pm fails you still write the
 value to the profile - is this intentional? Otherwise you can get rid of
 it since the caller gets the exception (cmd interface and the gui).
  - The set_*_pm methods needs to return 0 because these options do not
 require a sugar restart.

 profile.py

 I would let the profile return only a boolean value. This simplifies the
 code a bit.

 Attached I have the full patches (containing as well the svg we decided
 last night) with my suggestions.

 I tested as well on the XO and it worked all well :)

-- 
Ticket URL: <http://dev.laptop.org/ticket/7434#comment:7>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system


More information about the Bugs mailing list