#7339 BLOC 8.2.0 (: CPU Spinns after starting an activity

[Zarro Boogs per Child]

#7339: CPU Spinns after starting an activity
-----------------------+----------------------------------------------------
   Reporter:  benzea   |       Owner:  tomeu                  
       Type:  defect   |      Status:  new                    
   Priority:  blocker  |   Milestone:  8.2.0 (was Update.2)   
  Component:  sugar    |     Version:  Git as of bug date     
 Resolution:           |    Keywords:  8.2.0:? blocks:8.2.0 r+
Next_action:  code     |    Verified:  0                      
  Blockedby:           |    Blocking:                         
-----------------------+----------------------------------------------------
Changes (by mtd):

  * keywords:  8.2.0:? blocks:8.2.0 r? => 8.2.0:? blocks:8.2.0 r+


Comment:

 The attached patch 1) works (by inspection and by testing); 2) makes the
 code better; and 0) addresses a serious problem.  For all those reasons
 it's r+.

 Two comments:

 1) I'd consider removing the callback on active-activity-changed and
 replacing it with a callback on launch-failed.  Right now we don't catch
 launch-failed (so this would be a further improvement, and of course in
 the future we could do something pretty to assuage the user), so I think
 we'd still spin (looking at model/homemodel.py active-activity-changed
 won't help us here, IIUC).

 2) while I applaud the style cleanup in view/home/launchbox.py:75 (if
 activity: --> if activity is None:), you could probably put it in a
 separate patch.  But this is about the smallest of nits that someone could
 pick.  I - personally - do this too all the time.  Some people don't like
 it, but I think it helps more than it obfuscates.  So just FTR I mention
 it, but I personally think the more cleanup, the better.

 I think this should certainly be 8.2.0:+ but am not au fait enough with
 the keywords to be sure I'm allowed to change that.

-- 
Ticket URL: <http://dev.laptop.org/ticket/7339#comment:14>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system