#7248 NORM 8.2.0 (: Speaker device has inconsistent behavior

[Zarro Boogs per Child]

#7248: Speaker device has inconsistent behavior
-------------------------+--------------------------------------------------
   Reporter:  Eben       |       Owner:  mtd                              
       Type:  defect     |      Status:  assigned                         
   Priority:  normal     |   Milestone:  8.2.0 (was Update.2)             
  Component:  sugar      |     Version:  Development build as of this date
 Resolution:             |    Keywords:  8.2.0:+ r-                       
Next_action:  never set  |    Verified:  0                                
  Blockedby:             |    Blocking:  7420                             
-------------------------+--------------------------------------------------
Changes (by tomeu):

  * keywords:  8.2.0:+ r? => 8.2.0:+ r-


Comment:

 {{{
 +        'muted-changed' : (gobject.SIGNAL_RUN_FIRST,
 +                           gobject.TYPE_NONE,
 +                           ([gobject.TYPE_BOOLEAN,
 gobject.TYPE_BOOLEAN])),
 +        'volume-changed': (gobject.SIGNAL_RUN_FIRST,
 +                           gobject.TYPE_NONE,
 +                           ([gobject.TYPE_INT, gobject.TYPE_INT])),
 }}}

 Would be nice to convert muted and volume into properties, so we just used
 notify::muted to detect changes, but is not worth to delay this patch, I
 think.

 Also wonder if makes any sense to keep hardwaremanager.py. Maybe it should
 be merged into the different device model classes? We may enter tickets
 for 9.1, if agree on this.

 {{{
 +        self._sigids = []
 }}}

 This doesn't seem to be used?

 {{{
 +        vol_step = 10
 }}}

 Perhaps this should be a private constant? (in upper case and at the class
 or module level)

 {{{
 +                                          upper=100 + vol_step,
 }}}

 The upper limit is 110? I thought upper was a valid value in the
 adjustment.

 {{{
 +                                          step_incr=vol_step,
 }}}

 Wouldn't be nice to be able to move the slider smoothly percent by
 percent?

 The rest of the patch looked very good to me, thanks!

-- 
Ticket URL: <http://dev.laptop.org/ticket/7248#comment:16>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system