#5485 HIGH Update.: Doesn't accept my Wep key anymore

Zarro Boogs per Child bugtracker at laptop.org
Mon Jan 28 22:15:08 EST 2008


#5485: Doesn't accept my Wep key anymore
-----------------------+----------------------------------------------------
  Reporter:  gdesmott  |       Owner:  mbletsas
      Type:  defect    |      Status:  reopened
  Priority:  high      |   Milestone:  Update.1
 Component:  wireless  |     Version:          
Resolution:            |    Keywords:          
  Verified:  0         |    Blocking:          
 Blockedby:            |  
-----------------------+----------------------------------------------------

Comment(by dcbw):

 {{{
 261d52b4874d5575f98b494ad4e669154f141a94 is first bad commit
 commit 261d52b4874d5575f98b494ad4e669154f141a94
 Author: David Woodhouse <dwmw2 at infradead.org>
 Date:   Tue Dec 11 18:56:42 2007 -0500

     libertas: add lbs_mesh sysfs attribute for enabling mesh

     Signed-off-by: David Woodhouse <dwmw2 at infradead.org>

 :040000 040000 d3c51ed8fd49fe7bb5ed3b456d471e7b9d3aedc2
 ec9cd9f6baa37859b8039f9c62a874b9cbb1e165 M      drivers
 }}}

 WEP works before that commit (with
 fbbe497b58e3a5f1dca9cc363fc3957820e66299) but not with or after that
 commit.  I couldn't understand why that patch would affect WEP so I tried
 switching between those two commits manually and got the same results as
 the bisect.  Could something with mesh autostart be screwing us again?
 I'm using the latest "stable" firmware release from TechWiki
 (5.110.17.p5).

 Also, when bisecting, note that I usually had to manually fix up the build
 with:

 {{{
 diff --git a/drivers/net/wireless/libertas/assoc.c
 b/drivers/net/wireless/libertas/assoc.c
 index bd9cfe1..b93a51b 100644
 --- a/drivers/net/wireless/libertas/assoc.c
 +++ b/drivers/net/wireless/libertas/assoc.c
 @@ -171,8 +171,10 @@ static int update_channel(struct lbs_private *priv)
         lbs_deb_enter(LBS_DEB_ASSOC);

         ret = lbs_get_channel(priv);
 -       if (ret > 0)
 +       if (ret > 0) {
                 priv->curbssparams.channel = (u8) ret;
 +               ret = 0;
 +       }

         lbs_deb_leave_args(LBS_DEB_ASSOC, "ret %d", ret);
         return ret;
 }}}

 to fix the bug I introduced with my channel command refactor; otherwise
 the driver won't complete association.

-- 
Ticket URL: <http://dev.laptop.org/ticket/5485#comment:61>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system



More information about the Bugs mailing list