#6557 NORM Never A: sugar.activity.activity.Activity.save() buggy

[Zarro Boogs per Child]

#6557: sugar.activity.activity.Activity.save() buggy
--------------------+-------------------------------------------------------
 Reporter:  homunq  |       Owner:  marco                            
     Type:  defect  |      Status:  new                              
 Priority:  normal  |   Milestone:  Never Assigned                   
Component:  sugar   |     Version:  Development build as of this date
 Keywords:          |    Verified:  0                                
 Blocking:          |   Blockedby:                                   
--------------------+-------------------------------------------------------
 If I open without a dsobject, and creat_jobject is false, self._jobject
 gets set to None. But then save nonchalantly does:

             self.write_file(file_path)
             self._owns_file = True
             self._jobject.file_path = file_path

 without checking either write_file or self._jobject for existence.

 Also, I know that metadata should be in metadata, and I'm setting the
 right mime_type, but it still hurts not to put the right extension on my
 file. I don't know what magic occurs when copying to external storage, but
 having the right extension seems like the Right Thing To Do to me, and
 SPOT/DRY be damned.

 I will make a patch.

-- 
Ticket URL: <http://dev.laptop.org/ticket/6557>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system