#6436 BLOC Update.: Logging of values within Measure broken

Zarro Boogs per Child bugtracker at laptop.org
Wed Feb 13 12:32:12 EST 2008


#6436: Logging of values within Measure broken
-------------------------------+--------------------------------------------
  Reporter:  arjs              |       Owner:  dgilmore
      Type:  defect            |      Status:  new     
  Priority:  blocker           |   Milestone:  Update.1
 Component:  measure-activity  |     Version:          
Resolution:                    |    Keywords:          
  Verified:  0                 |    Blocking:          
 Blockedby:                    |  
-------------------------------+--------------------------------------------

Comment(by mstone):

 Looks plausible.

 The patch leaks a file descriptor when it discards the first value of the
 tuple returned by tempfile.mkstemp. Ideally, you would call os.close() on
 that fd.

 Also, the patch would be clearer to me if the commented-out-lines were
 removed entirely. Is there a reason for them to remain?

-- 
Ticket URL: <http://dev.laptop.org/ticket/6436#comment:2>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system



More information about the Bugs mailing list