#7823 HIGH 8.2.0 (: Non-modal alerts in CP remain when they shouldn't

[Zarro Boogs per Child]

#7823: Non-modal alerts in CP remain when they shouldn't
----------------------+-----------------------------------------------------
   Reporter:  Eben    |       Owner:  Eben                             
       Type:  defect  |      Status:  reopened                         
   Priority:  high    |   Milestone:  8.2.0 (was Update.2)             
  Component:  sugar   |     Version:  Development build as of this date
 Resolution:          |    Keywords:  8.2.0:+ r? joyride-2330:+        
Next_action:  review  |    Verified:  0                                
  Blockedby:          |    Blocking:                                   
----------------------+-----------------------------------------------------
Changes (by erikos):

  * keywords:  8.2.0:+ r+ joyride-2330:+ => 8.2.0:+ r? joyride-2330:+
  * status:  closed => reopened
  * next_action:  finalize => review
  * resolution:  fixed =>


Comment:

 {{{
 diff --git a/src/controlpanel/gui.py b/src/controlpanel/gui.py
 index 3b237a6..4f56884 100644
 --- a/src/controlpanel/gui.py
 +++ b/src/controlpanel/gui.py
 @@ -256,6 +256,7 @@ class ControlPanel(gtk.Window):
      def __cancel_clicked_cb(self, widget):
          self._section_view.undo()
          self._options[self._current_option]['alerts'] = []
 +        self._section_toolbar.accept_button.set_sensitive(True)
          self._show_main_view()

      def __accept_clicked_cb(self, widget):
 }}}

 We need this to go in as well. Otherwise we fail for options that has an
 error and where we cancel then. To make clear what I mean a testcase:

 |TestCase|

 open the aboutme section in the control panel. remove all of the nick. The
 'valid' button will be insensitive since you must enter a valid nick name.
 Hit 'cancel'. Open the aboutme section again. The 'valid' button should be
 sensitive again.

-- 
Ticket URL: <http://dev.laptop.org/ticket/7823#comment:11>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system