#6929 NORM 8.2.0 (: Sugar should include a string that explains that it is free software and under the GPL

[Zarro Boogs per Child]

#6929: Sugar should include a string that explains that it is free software and
under the GPL
----------------------+-----------------------------------------------------
   Reporter:  mako    |       Owner:  dsd                 
       Type:  defect  |      Status:  new                 
   Priority:  normal  |   Milestone:  8.2.0 (was Update.2)
  Component:  sugar   |     Version:                      
 Resolution:          |    Keywords:  8.2.0:? r?          
Next_action:  review  |    Verified:  0                   
  Blockedby:          |    Blocking:  4265                
----------------------+-----------------------------------------------------

Comment(by marco):

 Please separate the widget creation code in different blocks (single \n).
 You are doing it in some places, but not consistently

 {{{
 +    license_file = _("/usr/share/licenses/common-licenses/GPL-2")
 }}}

 Do we need to rely on a translated string for this? It seems like we could
 just figure out the path in the code from the current lang codes.

 {{{
 +        label_info = gtk.Label(_("Sugar is the graphical user interface
 that you are looking at. Sugar is free software, covered by the GNU
 General Public License, and you are welcome to change it and/or distribute
 copies of it under certain conditions described therein."))
 }}}

 80 cols, please split the string up. This makes me think you didn't pylint
 the code. Please do so, see the note about pylint here:

 http://sugarlabs.org/go/DevelopmentTeam/CodeReview#Buildbot

 {{{
 +        label_info.set_size_request(600, -1)
 }}}

 I'd make this screen size relative gtk.gdk.screen_width() / 2 or
 something.

 {{{
 +            view_license.set_border_window_size(gtk.TEXT_WINDOW_LEFT, 1)
 +            view_license.set_border_window_size(gtk.TEXT_WINDOW_RIGHT, 1)
 +            view_license.set_border_window_size(gtk.TEXT_WINDOW_TOP, 1)
 +            view_license.set_border_window_size(gtk.TEXT_WINDOW_BOTTOM,
 1)
 }}}

 Do we actually want this border? In what color is it rendered? Eben?

 {{{
 +            view_license.set_left_margin(3)
 }}}

 Why a margin only on the left? I'd prefer to use style.DEFAULT_PADDING
 anyway.

-- 
Ticket URL: <http://dev.laptop.org/ticket/6929#comment:19>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system