#7733 BLOC 8.2.0 (: Cannot install Wikipedia-10.xo

[Zarro Boogs per Child]

#7733: Cannot install Wikipedia-10.xo
-----------------------+----------------------------------------------------
   Reporter:  tomeu    |       Owner:  tomeu                           
       Type:  defect   |      Status:  new                             
   Priority:  blocker  |   Milestone:  8.2.0 (was Update.2)            
  Component:  sugar    |     Version:  Git as of bug date              
 Resolution:           |    Keywords:  8.2.0:? blocks?:8.2.0 relnote r+
Next_action:  review   |    Verified:  0                               
  Blockedby:           |    Blocking:                                  
-----------------------+----------------------------------------------------

Comment(by cscott):

 Replying to [comment:28 tomeu]:
 >  - Releasing the zip file in __del__() will delay the actual release of
 the instance in case of a cycle, is this a problem in this case?

 It's hard to imagine how we'd create a cycle with a ZipFile.  I suppose we
 could pass it a file-like object which holds a reference to the ZipFile it
 was passed to, but that would be very broken.  __del__ should not be a
 problem.

 >  - _packed reads like a flag to me, I'd prefer if this variable was
 named _zip_file instead.

 I'll make that change before committing.

-- 
Ticket URL: <http://dev.laptop.org/ticket/7733#comment:30>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system