#7733 BLOC 8.2.0 (: Cannot install Wikipedia-10.xo
Zarro Boogs per Child
bugtracker at laptop.org
Tue Aug 19 13:25:44 EDT 2008
#7733: Cannot install Wikipedia-10.xo
-----------------------+----------------------------------------------------
Reporter: tomeu | Owner: tomeu
Type: defect | Status: new
Priority: blocker | Milestone: 8.2.0 (was Update.2)
Component: sugar | Version: Git as of bug date
Resolution: | Keywords: 8.2.0:? blocks?:8.2.0 relnote r+
Next_action: review | Verified: 0
Blockedby: | Blocking:
-----------------------+----------------------------------------------------
Changes (by tomeu):
* keywords: 8.2.0:? blocks?:8.2.0 relnote r? => 8.2.0:? blocks?:8.2.0
relnote r+
Comment:
Both patches look pretty good to me, just two comments:
- Releasing the zip file in __del__() will delay the actual release of
the instance in case of a cycle, is this a problem in this case?
- _packed reads like a flag to me, I'd prefer if this variable was named
_zip_file instead.
Anyway, r+
--
Ticket URL: <http://dev.laptop.org/ticket/7733#comment:28>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system
More information about the Bugs
mailing list