#7970 NORM 8.2.0 (: Some CP modules set needs_restart to False when they shouldn't

[Zarro Boogs per Child]

#7970: Some CP modules set needs_restart to False when they shouldn't
---------------------+------------------------------------------------------
 Reporter:  Eben     |         Owner:  Eben                             
     Type:  defect   |        Status:  new                              
 Priority:  normal   |     Milestone:  8.2.0 (was Update.2)             
Component:  sugar    |       Version:  Development build as of this date
 Keywords:  8.2.0:?  |   Next_action:  code                             
 Verified:  0        |     Blockedby:                                   
 Blocking:           |  
---------------------+------------------------------------------------------
 It seems to me that the needs_restart boolean should only ever be changed
 to True (until the next time the module is reinitialized, of course).
 Several of them currently set this flag to False when they encounter an
 error adjusting the setting, which could inadvertently unset the flag even
 though other settings still require it.

 Simon, was there any specific reason for the current behavior? I'll attach
 a patch for this shortly.

-- 
Ticket URL: <http://dev.laptop.org/ticket/7970>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system