#7733 BLOC 8.2.0 (: Cannot install Wikipedia-10.xo

[Zarro Boogs per Child]

#7733: Cannot install Wikipedia-10.xo
-----------------------+----------------------------------------------------
   Reporter:  tomeu    |       Owner:  tomeu                           
       Type:  defect   |      Status:  new                             
   Priority:  blocker  |   Milestone:  8.2.0 (was Update.2)            
  Component:  sugar    |     Version:  Git as of bug date              
 Resolution:           |    Keywords:  8.2.0:? blocks?:8.2.0 relnote r?
Next_action:  review   |    Verified:  0                               
  Blockedby:           |    Blocking:                                  
-----------------------+----------------------------------------------------

Comment(by cscott):

 Profiling the code reveals that we spend 588 seconds (on my fast Thinkpad)
 in sugar.bundle.bundle.is_file().  It apparently takes a few seconds to
 load the ZipFile in line 125, and we repeat this operation (unnecessarily)
 for each one of the 3,176 files in the bundle.  This is unacceptable, and
 is about the least efficient way possible to check the (otherwise unused)
 MANIFEST file.

 Commenting out 'self.read_manifest()' on line 69 of
 sugar.bundle.activitybundle.py fixes the performance problem (the code
 above completes in 4 seconds on an XO) and allows sugar-install-bundle of
 Wikipedia-10.xo to succeed.  This is probably the smallest possible patch
 for this regression.

-- 
Ticket URL: <http://dev.laptop.org/ticket/7733#comment:23>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system