#7730 NORM 8.2.0 (: Clicking on Speaker icon should Mute/Unmute Sound

[Zarro Boogs per Child]

#7730: Clicking on Speaker icon should Mute/Unmute Sound
---------------------------+------------------------------------------------
   Reporter:  HoboPrimate  |       Owner:  rgs1                
       Type:  enhancement  |      Status:  new                 
   Priority:  normal       |   Milestone:  8.2.0 (was Update.2)
  Component:  sugar        |     Version:  Git as of bug date  
 Resolution:               |    Keywords:  8.2.0:? r?          
Next_action:  review       |    Verified:  1                   
  Blockedby:               |    Blocking:                      
---------------------------+------------------------------------------------

Comment(by mtd):

 Replying to [comment:7 rgs1]:
 Thanks for the patch!

 Two comments:

 1) Please put a space after each comma on lines 52 and 69  (see
 http://www.python.org/dev/peps/pep-0008/ and
 http://wiki.laptop.org/go/Python_Style_Guide ).

 2) can you check as to whether the "notify::muted" event gets emitted when
 you change the muted property on line 70?  If it does, then you don't need
 line 71.  If it doesn't, I'd consider replacing line 72 with a
 self.emit("muted") to notify all your observers (and the _update_info()
 would get done as a consequence).

 r+ with those changes, and thanks again!

-- 
Ticket URL: <http://dev.laptop.org/ticket/7730#comment:9>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system