#3652 HIGH Trial-3: State of mixer settings not stored when shutdown

[Zarro Boogs per Child]

#3652: State of mixer settings not stored when shutdown
---------------------+------------------------------------------------------
  Reporter:  Simon   |       Owner:  marco  
      Type:  defect  |      Status:  new    
  Priority:  high    |   Milestone:  Trial-3
 Component:  distro  |     Version:         
Resolution:          |    Keywords:  relnote
  Verified:  0       |  
---------------------+------------------------------------------------------
Changes (by marco):

 * cc: review? (removed)
 * cc: review- (added)


Comment:

 {{{
 +    if env.is_emulator() is False:
 +        hw_manager = hardwaremanager.get_manager()
 +        hw_manager.startup()
 }}}

 Startup should be called also on the emulator. Please add a check in
 hw.startup instead.

 {{{
 +        if env.is_emulator() is False:
 +            _set_key(cp, 'Sound', 'Volume', self.sound_volume)
 +
 }}}

 We can avoid this check. The important is that we avoid to restore volume
 in the emulator (in hardwaremanager), if we save it, it doesn't matter.

 {{{
 +        self.sound_volume = 81
 }}}

 Similarly to DEFAULT_JABBER_SERVER, define the 81 as DEFAULT_VOLUME.

 {{{
 +        if cp.has_option('Sound', 'Volume'):
 +            self.sound_volume = float(cp.get('Sound', 'Volume'))
 }}}

 Please handle the ValueError exception here (set it to DEFAULT_VOLUME in
 that case).

-- 
Ticket URL: <https://dev.laptop.org/ticket/3652#comment:6>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system