#3506 HIGH Trial-3: XOs connected to jabber server AND can link local don't share well

[Zarro Boogs per Child]

#3506: XOs connected to jabber server AND can link local don't share well
------------------------------+---------------------------------------------
  Reporter:  kimquirk         |       Owner:  dcbw    
      Type:  defect           |      Status:  assigned
  Priority:  high             |   Milestone:  Trial-3 
 Component:  network manager  |     Version:          
Resolution:                   |    Keywords:          
  Verified:  0                |  
------------------------------+---------------------------------------------
Changes (by dcbw):

  * status:  new => assigned


Comment:

 There are two bugs fixed in this patch, one uncovered by the first.

 1) Make the plugins mutually exclusive.  When Gabble is active, Salut is
 disabled, and vice versa.  Gabble takes precedence.

 2) The changes in telepathy_plugin.py fix 3 bugs uncovered by the first
 fix
 2a) When the gabble plugin is stopped when the machines IP address becomes
 invalid, the disconnected signal was never emitted, causing (1) above not
 to work correctly.
 2b) self._conn must be cleared _after_ removing contacts, since removing
 the TP handle from the buddy requires self._conn.service_name to be valid
 2c) Calling self._contacts_offline(self._online_contacts) passes that
 value by reference apparently, leading the code in _contacts_offline() to
 subtract self._contacts_online from itself, but oddly enough since
 'handle' was just an alias to self._contacts_online, handle was also
 cleared by the -= operation, and therefore was blank when the 'contacts-
 offline' signal got emitted.  Work around that by copying the values
 instead of passing a reference to self._contacts_online.

-- 
Ticket URL: <https://dev.laptop.org/ticket/3506#comment:3>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system