#4565 BLOC Update.: Salut crashes with assertion failure during activity sharing

[Zarro Boogs per Child]

#4565: Salut crashes with assertion failure during activity sharing
-----------------------------+----------------------------------------------
 Reporter:  smcv             |       Owner:  smcv                             
     Type:  defect           |      Status:  new                              
 Priority:  blocker          |   Milestone:  Update.1                         
Component:  telepathy-salut  |     Version:  Development build as of this date
 Keywords:  Update.1?        |    Verified:  0                                
-----------------------------+----------------------------------------------
 The fix for #4503 calls RequestChannel more than once for the same channel
 (once in Presence Service and once in the activity). This is allowed by
 the API and is a sensible thing to do, but at the moment it causes an
 assertion failure in telepathy-salut:

 {{{
 ** (telepathy-salut:10490): DEBUG: channel_request_new: New channel
 request at 0x80aac68: ctype=org.freedesktop.Telepathy.Channel.Type.Text
 htype=2 handle=1 suppress=1
 ** (telepathy-salut:10490): DEBUG:
 salut_muc_manager_factory_iface_request: MUC request:
 ctype=org.freedesktop.Telepathy.Channel.Type.Text htype=2 handle=1
 ** (telepathy-salut:10490): DEBUG: satisfy_requests: called for
 /org/freedesktop/Telepathy/Connection/salut/local_2dxmpp/_30f8b0e29/MucChannel/1
 ** (telepathy-salut:10490): DEBUG: satisfy_requests: completing queued
 request 0x80aac68 with success,
 channel_type=org.freedesktop.Telepathy.Channel.Type.Text, handle_type=2,
 handle=1, suppress_handler=1
 ** (telepathy-salut:10490): DEBUG: channel_request_free: Freeing channel
 request at 0x80aac68: ctype=org.freedesktop.Telepathy.Channel.Type.Text
 htype=2 handle=1 suppress=1
 ** (telepathy-salut:10490): DEBUG: channel_request_new: New channel
 request at 0x80aac80: ctype=org.freedesktop.Telepathy.Channel.Type.Tubes
 htype=2 handle=1 suppress=1
 ** (telepathy-salut:10490): DEBUG:
 salut_muc_manager_factory_iface_request: MUC request:
 ctype=org.freedesktop.Telepathy.Channel.Type.Tubes htype=2 handle=1

 ** ERROR **: file base-connection.c: line 1158
 (tp_base_connection_request_channel): assertion failed: (NULL != chan)
 aborting...
 }}}

 This is due to incorrect handling of existing tubes channels. I believe
 there is a one-line fix.

-- 
Ticket URL: <https://dev.laptop.org/ticket/4565>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system