#4484 BLOC Reload: OFW uses wrong EC command for write protect

[Zarro Boogs per Child]

#4484: OFW uses wrong EC command for write protect
---------------------------------+------------------------------------------
 Reporter:  wmb at firmworks.com    |       Owner:  wmb at firmworks.com      
     Type:  defect               |      Status:  new                    
 Priority:  blocker              |   Milestone:  Reload                 
Component:  ofw - open firmware  |     Version:  OFW development version
 Keywords:                       |    Verified:  0                      
---------------------------------+------------------------------------------
 From rsmith:

 Q2DO2 cannot be used for MP.  In secure boot mode it will incorrectly
 rewrite the battery EEPROM values.

 Summary:

 Quanta changed the SPI flash write protect command from 0x29 to 0x03 in
 PQ2C15 and did not tell OLPC.

 In Q2D01 Quanta added a new EC command and re-used the 0x29.  This command
 forces an update of the values in the battery EEPROM.  OLPC was not told
 of this and it there is no mention of it in the release notes.

 OpenFirmware is still using the orginal value of 0x29 for write protecting
 the SPI flash but now it means update EEPROM.  So in secure boot mode
 Q2D01 and Q2D02 can write incorrect into the battery EEPROM info.

 Fix:

 The fix is a simple one line change in OFW but we will need a new firmware
 spin.

-- 
Ticket URL: <https://dev.laptop.org/ticket/4484>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system