#1498 HIGH Future : vserver needs cleanup

[Zarro Boogs per Child]

#1498: vserver needs cleanup
---------------------+------------------------------------------------------
  Reporter:  jg      |       Owner:  dilinger      
      Type:  task    |      Status:  new           
  Priority:  high    |   Milestone:  Future Release
 Component:  kernel  |     Version:                
Resolution:          |    Keywords:  security      
  Verified:  0       |  
---------------------+------------------------------------------------------

Comment(by bertl):

 hmm ... CodingStyle (from kernel Documentation) says:

 ''Generally, inline functions are preferable to macros resembling
 functions.''

 also the section about inlines states:

 ''A reasonable rule of thumb is to not put inline at functions that have
 more
 than 3 lines of code in them. An exception to this rule are the cases
 where
 a parameter is known to be a compiletime constant, and as a result of this
 constantness you *know* the compiler will be able to optimize most of your
 function away at compile time. For a good example of this later case, see
 the kmalloc() inline function.''

 note: it doesn't state anything about nesting levels.

 I will go through the Linux-VServer inline functions and see where the
 inline can be removed without adverse effects, please be so kind and
 provide an example with the 'proper' solution (as you see it) which
 doesn't harm performance, code size or functionality.

-- 
Ticket URL: <https://dev.laptop.org/ticket/1498#comment:9>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system