#2412 BLOC First D: Buddies not disappearing even when connection does

[Zarro Boogs per Child]

#2412: Buddies not disappearing even when connection does
-------------------------------+--------------------------------------------
  Reporter:  Zack              |       Owner:  morgs                 
      Type:  defect            |      Status:  new                   
  Priority:  blocker           |   Milestone:  First Deployment, V1.0
 Component:  presence-service  |     Version:                        
Resolution:                    |    Keywords:  collaboration         
  Verified:  0                 |  
-------------------------------+--------------------------------------------
Changes (by smcv):

  * owner:  smcv => morgs


Comment:

 Replying to [comment:21 morgs]:
 > Replying to [comment:20 smcv]:
 > > - When connections signal that they have become disconnected via the
 Telepathy API, ensure that we remove the relevant handle from all buddies
 on that connection, causing them to emit BuddyDisappeared if they are not
 visible on any other connection
 >
 > Looks like we don't.

 OK, please implement that on a branch. Ping me for review.

 > > - When N-M reports a disconnection, do we forcibly close Gabble
 connections?
 >
 > We do self._conn[CONN_INTERFACE].Disconnect() (wrapped in an evil try:
 except: pass)

 `except dbus.DBusException, e: some_logger_or_other.debug('%s
 Disconnect(): %s', conn.object_path, e)` please :-)

 > > It probably makes sense to close Gabble connections immediately if our
 IP address changes from one non-empty value to another, though, since that
 means we lose continuity anyway.

 Lower priority but yes please.

 > AFAICT Salut always runs when gabble doesn't, assuming it can see avahi
 on the system bus. Only gabble starting stops salut.

 Great, as long as Gabble stopping starts Salut, we're doing the right
 thing in all cases then.

 While you're touching this code already, it might be useful to incorporate
 some more debug so we can get some idea what's happening in the various
 "I'm on an AP but Gabble isn't connected" bugs. Have a look at Yani's bug?

-- 
Ticket URL: <https://dev.laptop.org/ticket/2412#comment:22>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system