#4357 NORM Never A: activity.share() method 'FIXME' Make private=True to ...

[Zarro Boogs per Child]

#4357: activity.share() method 'FIXME' Make private=True to ...
-------------------------------+--------------------------------------------
  Reporter:  pascal            |       Owner:  morgs         
      Type:  defect            |      Status:  closed        
  Priority:  normal            |   Milestone:  Never Assigned
 Component:  presence-service  |     Version:                
Resolution:  fixed             |    Keywords:                
  Verified:  0                 |  
-------------------------------+--------------------------------------------
Changes (by morgs):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 I've removed the FIXME, since we are now explicitly calling share with
 private=True and private=False. The only time it makes sense to have a
 default is if an activity calls "self.share()" itself with no args, as
 Chat did before invites were possible.

 As far as I'm aware, no other activities are doing this, and if they are,
 public is a sane default after all until they fix the activity.

-- 
Ticket URL: <https://dev.laptop.org/ticket/4357#comment:1>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system