#4266 NORM Never A: Warning with a traceback every time an activity starts

[Zarro Boogs per Child]

#4266: Warning with a traceback every time an activity starts
---------------------+------------------------------------------------------
 Reporter:  smcv     |       Owner:  smcv              
     Type:  defect   |      Status:  new               
 Priority:  normal   |   Milestone:  Never Assigned    
Component:  sugar    |     Version:  Git as of bug date
 Keywords:  review?  |    Verified:  0                 
---------------------+------------------------------------------------------
 sugar.presence.presenceservice.PresenceService.get_activity assumes that
 failure to get the activity merits a warning. However,
 sugar.activity.activity.Activity.__init__ uses get_activity to determine
 whether Presence Service has an object representing the shared activity or
 not. In this case, failure is completely benign, and we shouldn't log a
 warning.

 Logging warnings that aren't actually a problem is distracting when
 debugging problems, so we should try to avoid it.

 I propose to add an optional warn_if_none argument to get_activity, with
 default True to preserve the old behaviour, and make Activity.__init__
 pass warn_if_none=False to silence the warning.

-- 
Ticket URL: <https://dev.laptop.org/ticket/4266>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system