#4218 LOW Never A: Pippy's "Run!" and "Stop!" buttons are not visible in qemu (resolution problem)

[Zarro Boogs per Child]

#4218: Pippy's "Run!" and "Stop!" buttons are not visible in qemu (resolution
problem)
----------------------------+-----------------------------------------------
 Reporter:  vorburger       |       Owner:  cjb           
     Type:  defect          |      Status:  new           
 Priority:  low             |   Milestone:  Never Assigned
Component:  pippy-activity  |     Version:                
 Keywords:  review?         |    Verified:  1             
----------------------------+-----------------------------------------------
 Those "Run!" and "Stop!" buttons in Pippy do NOT show when running build
 613 under qemu... as in they are probably 2 pixels thin and if you know
 they are there, barely clickable.

 A quick IRC chat on #sugar with cjb tells this does work on the XO HW and
 in jhbuild, so is a low prio qemu-only problem probably due to the
 different resolution?

 The fix seems to be easy: Specify -1 instead of the current 2 (pixels??)
 as height for those buttons.

 Sorry guys that I'm not on git (yet) - I am just getting my teeth into
 Sugar, GTK & Co.  so for now accept this as my manual "diff":

 Line 133: replace gobutton.set_size_request(800, 2) with (800, -1)
 Line 139: replace stopbutton.set_size_request(200, 2) with (200, -1)

 My proposed patch should probably be verified by somebody using XO HW (can
 I get one?? ;) and in jhbuild, but according to
 http://www.pygtk.org/docs/pygtk/class-gtkwidget.html#method-gtkwidget
 --set-size-request the -1 "unsets" any forced height (so we only force the
 width) and seems safe.

 Regards,
 Michael Vorburger

-- 
Ticket URL: <https://dev.laptop.org/ticket/4218>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system