#4027 LOW First D: Misleading debug messages suggest that activity properties are copied to wrong activity (was: Activity properties somehow copied to wrong activity (unreproducible))

[Zarro Boogs per Child]

#4027: Misleading debug messages suggest that activity properties are copied to
wrong activity
---------------------+------------------------------------------------------
  Reporter:  bemasc  |       Owner:  marco                            
      Type:  defect  |      Status:  new                              
  Priority:  low     |   Milestone:  First Deployment, V1.0           
 Component:  sugar   |     Version:  Development build as of this date
Resolution:          |    Keywords:  collaboration, review?           
  Verified:  0       |  
---------------------+------------------------------------------------------
Changes (by smcv):

 * cc: morgs, dcbw, marco (added)
  * keywords:  telepathy sharing activity hellomesh sugar => collaboration,
               review?
  * component:  telepathy-other => sugar
  * owner:  smcv => marco


Comment:

 The first attached patch is to sugar. I suspect the bug is actually that
 the log messages are misleading.

 However, if bemasc is correct and the activity properties really are
 getting copied from activity to activity, applying the second patch (to
 presence-service) will produce logs that might let us work out what's
 wrong when it happens again.

 There's also a Sugar client-library API bug here - creating a
 sugar.presence.activity.Activity appears to be intended to mean "I am
 interested in this activity, please signal me when anything happens to
 it". However, when sugar.presence.presenceservice.PresenceService emits an
 activity-appeared signal, the signal contains an s.p.a.Activity (which
 will almost immediately be garbage-collected if nobody cared about the
 signal, as will be the case in most (all?) activities, although not in the
 Shell). This produces unnecessary D-Bus traffic between the PS and every
 activity process.

-- 
Ticket URL: <https://dev.laptop.org/ticket/4027#comment:5>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system