#3757 HIGH First D: Correct way of displaying bundles in the journal using the .activity information

[Zarro Boogs per Child]

#3757: Correct way of displaying bundles in the journal using the .activity
information
-------------------------------+--------------------------------------------
  Reporter:  AlexL             |       Owner:  erikos                
      Type:  defect            |      Status:  new                   
  Priority:  high              |   Milestone:  First Deployment, V1.0
 Component:  journal-activity  |     Version:                        
Resolution:                    |    Keywords:  review-               
  Verified:  0                 |  
-------------------------------+--------------------------------------------
Changes (by tomeu):

 * cc: tomeu (added)
  * keywords:  review? => review-
  * owner:  tomeu => erikos


Comment:

 >
 {{{
 -            self._icon.props.fill_color=style.COLOR_TRANSPARENT.get_svg()
 -            self._icon.props.stroke_color=style.COLOR_BLACK.get_svg()
 }}}

 We are not setting the colors of the entry any more?

 >
 {{{
 +            if 'title_set_by_user' in jobject.metadata and \
 +                   jobject.metadata['title_set_by_user'] is not '1':
 }}}

 What about this:
 {{{
 if jobject.metadata.get('title_set_by_user', '0') == '0':
 }}}


 >
 {{{
 +                title = name + _(' Activity ') + str(version)
 }}}

 Perhaps this could be clearer?
 {{{
            title = _('%s Activity %i') % (name, version)
 }}}


 Other than that, the patch looks good to me

-- 
Ticket URL: <https://dev.laptop.org/ticket/3757#comment:9>
One Laptop Per Child <https://dev.laptop.org>
OLPC bug tracking system