#5106 HIGH Update.: Attaching a file to gmail msg caused the journal to crash

[Zarro Boogs per Child]

#5106: Attaching a file to gmail msg caused the journal to crash
-------------------------------+--------------------------------------------
  Reporter:  kimquirk          |       Owner:  tomeu   
      Type:  defect            |      Status:  new     
  Priority:  high              |   Milestone:  Update.1
 Component:  journal-activity  |     Version:          
Resolution:                    |    Keywords:  review+ 
  Verified:  0                 |  
-------------------------------+--------------------------------------------
Changes (by tomeu):

  * keywords:  => review+


Comment:

 The two patches attached implement the object chooser as an action
 callable through dbus.

 Despite their size, I think they are not very invasive for the following
 reasons:

  - In the journal, most changes are additive. The modifications to
 ListView and CollapsedObject are just for hiding the resume button. If
 considered prudent, we could back off those changes.

  - In sugar, the changes are limited to sugar.graphics.objectchooser. We
 totally replace its implementation, but as it was already broken before,
 we cannot regress much due to this patch.

 This patch doesn't maintain compatibility with the older API. The new API
 is simpler, as users don't have to interact with the gtk Dialog API.
 Switching activities to the new API is trivial, almost a matter of
 deleting code.

 If really needed, we can provide an API for backwards compatibility, but
 giving the small number of activities using that functionality, I think it
 might not be worth.

-- 
Ticket URL: <http://dev.laptop.org/ticket/5106#comment:7>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system