#4871 NORM Update.: the write save as entries of the journal come up uncolored

[Zarro Boogs per Child]

#4871: the write save as entries of the journal come up uncolored
-------------------------------+--------------------------------------------
  Reporter:  erikos            |       Owner:  rwh              
      Type:  defect            |      Status:  new              
  Priority:  normal            |   Milestone:  Update.1         
 Component:  journal-activity  |     Version:                   
Resolution:                    |    Keywords:  Update.1? review+
  Verified:  0                 |  
-------------------------------+--------------------------------------------
Changes (by tomeu):

 * cc: tomeu (added)
  * keywords:  Update.1? review? => Update.1? review+


Comment:

 {{{
 icon_color = self._activity.metadata['icon-color']
 fileObject.metadata['icon-color'] = icon_color
 }}}

 Why not this:

 {{{
 fileObject.metadata['icon-color'] = act_meta['icon-color']
 }}}

 {{{
 #        self._activity.take_screenshot()
 #        if self._activity._preview:
 #            preview = self._activity._get_preview()
 #            fileObject.metadata['preview'] = dbus.ByteArray(preview)
 }}}

 Should this block include a TODO note pointing to one actual ticket in
 trac?

 Review+ if rwh agrees with the comments.

-- 
Ticket URL: <http://dev.laptop.org/ticket/4871#comment:8>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system