#4941 HIGH Update.: How to tell version

[Zarro Boogs per Child]

#4941: How to tell version
---------------------+------------------------------------------------------
  Reporter:  bert    |       Owner:  erikos            
      Type:  defect  |      Status:  new               
  Priority:  high    |   Milestone:  Update.1          
 Component:  sugar   |     Version:                    
Resolution:          |    Keywords:  Update.1?, review+
  Verified:  0       |  
---------------------+------------------------------------------------------
Changes (by marco):

  * keywords:  Update.1?, review? => Update.1?, review+


Comment:

 {{{
 +    def _read_file(self, path):
 +        if os.access(path, os.R_OK) == 0:
 +            _logger.error('read_file() No such file or directory: %s',
 path)
 +            return "No Info available"
 }}}

 The string should be translated. Also maybe it should be "Not Available"?.
 You will also have to store it in a variable to avoid duplicate
 translations (you are returning the same string at the end of the method).

 {{{
 +        if len(value) > 0:
 }}}

 We can just use "if value" there, see style guide.

 {{{
 +            widget.hide()
 +            widget.destroy()
 }}}

 Do we really need to first hide and then destroy here?

 review+ with this changes

-- 
Ticket URL: <http://dev.laptop.org/ticket/4941#comment:8>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system