#4612 HIGH Update.: Sugar doesn't notice activities failing to launch

[Zarro Boogs per Child]

#4612: Sugar doesn't notice activities failing to launch
---------------------+------------------------------------------------------
  Reporter:  cjb     |       Owner:  rwh     
      Type:  defect  |      Status:  new     
  Priority:  high    |   Milestone:  Update.1
 Component:  sugar   |     Version:          
Resolution:          |    Keywords:          
  Verified:  0       |  
---------------------+------------------------------------------------------

Comment(by marco):

 Replying to [comment:9 rwh]:
 > Ah, of course. But can't we do a gobject.child_watch_add(pid) in
 Rainbow, and then inform the shell that the process has ended by calling
 something like Shell.NotifyProcessFinished? If the shell has not found a
 window by then, the activity failed to launch, right? (except for cases
 where the process spawns a subprocesses in the background, so maybe we
 still need a timeout anyway).
 >

 Rainbow could emit a dbus signal. As you say there is no guarantee that
 the main process exiting will mean the activity exited though. In "process
 spawn a subprocess" case rainbow would be emitting a Exited signal and the
 shell would incorrectly remove the notification icon.

 > For now we can add a timeout that triggers a launch_timedout() call
 automatically after about a minute. Does that time sound right?

 Looks like the old dbus code was using a timeout of 2 minutes. That was
 tuned on the GX though, 1.5 seem reasonable now.

-- 
Ticket URL: <http://dev.laptop.org/ticket/4612#comment:10>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system