#4871 NORM Update.: the write save as entries of the journal come up uncolored

[Zarro Boogs per Child]

#4871: the write save as entries of the journal come up uncolored
-------------------------------+--------------------------------------------
  Reporter:  erikos            |       Owner:  rwh              
      Type:  defect            |      Status:  new              
  Priority:  normal            |   Milestone:  Update.1         
 Component:  journal-activity  |     Version:                   
Resolution:                    |    Keywords:  Update.1? review?
  Verified:  0                 |  
-------------------------------+--------------------------------------------

Comment(by Eben):

 Replying to [comment:5 tomeu]:
 > {{{
 >         icon_color = sugar.profile.get_color().to_string()
 >         fileObject.metadata['icon-color'] = icon_color
 > }}}
 >
 > Eben, ok to create the entry with the local colors?

 Walter nor I have strong feelings about this, though I think that
 retaining the colors of the current object would be better.  Consider for
 instance, a story that you wrote.  If I create a .pdf of that story you're
 still the Author.  Likewise for a TamTam composition that I export to an
 audio file.

 > {{{
 >         fileObject.metadata['activity_id'] = act_meta['activity_id']
 > }}}
 >
 > Same activity id? Eben?

 No, definitely not.  This is a new object, perhaps of a new type (may not
 even open with the same activity).  It should have a brand new activity
 ID, and it should have a private scope by default as well.  Although this
 may be your story, or even our story, when I create a new object based on
 it it's my own personal copy (until, of course, I share it with you if I
 want to...).

 > {{{
 >         fileObject.metadata['keep'] = act_meta['keep']
 > }}}
 >
 > One more question for Eben. Should the new entry be starred if the
 original one was?

 Sure, after a little thought I think that's a nice idea.  In some cases, I
 might create a new format with the intention of deleting the object which
 it came from.  Retaining star status prevents me from accidentally losing
 the converted object if I forget to start it myself when removing its
 source.  If I do prefer one format to be starred over another, I can
 manage that myself anyway.

 > {{{
 >         self._activity.take_screenshot()
 >         if self._activity._preview:
 >             preview = self._activity._get_preview()
 >             fileObject.metadata['preview'] = dbus.ByteArray(preview)
 > }}}
 >
 > We certainly shouldn't access any private members of other classes. I
 would prefer for this entries to not have previews until we have a good
 way to do this.

-- 
Ticket URL: <http://dev.laptop.org/ticket/4871#comment:6>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system