#4962 NORM Never A: FriendView._get_new_icon_name not working

[Zarro Boogs per Child]

#4962: FriendView._get_new_icon_name not working
---------------------+------------------------------------------------------
  Reporter:  rwh     |       Owner:  rwh           
      Type:  defect  |      Status:  new           
  Priority:  normal  |   Milestone:  Never Assigned
 Component:  distro  |     Version:                
Resolution:          |    Keywords:  review+       
  Verified:  0       |  
---------------------+------------------------------------------------------
Changes (by marco):

  * keywords:  review? => review+


Comment:

 {{{
      def _buddy_activity_changed_cb(self, buddy, home_activity=None):
 +         #home_activity is actually a proxy for a
 presenceservice.Activity DBUS object
 }}}

 Ugh, please rename to activity or ps_activity there. home_activity is
 really confusing. This probably makes the comment unnecessary. review+
 with that change.

-- 
Ticket URL: <http://dev.laptop.org/ticket/4962#comment:2>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system