#2318 NORM FutureF: Changing the "Open" functionality of CTRL-O shortcut

Zarro Boogs per Child bugtracker at laptop.org
Tue Nov 20 06:23:26 EST 2007


#2318: Changing the "Open" functionality of CTRL-O shortcut
--------------------------+-------------------------------------------------
  Reporter:  mcfletch     |       Owner:  rwh                              
      Type:  enhancement  |      Status:  new                              
  Priority:  normal       |   Milestone:  FutureFeatures                   
 Component:  sugar        |     Version:  Development build as of this date
Resolution:               |    Keywords:  review?                          
  Verified:  0            |  
--------------------------+-------------------------------------------------
Changes (by tomeu):

 * cc: tomeu (added)
  * owner:  tomeu => rwh


Comment:

 {{{
         activity = self._shell.get_current_activity()._model
 }}}

 We shouldn't access _model from outside the class that declares it. It is
 a private member.

 About the patch for the journal, I would prefer if the actual setting up
 of the query was done inside the SearchToolbar. We should maximize
 cohesion and minimize coupling between classes. What do you think about my
 patch at #4275 for this same thing?

-- 
Ticket URL: <http://dev.laptop.org/ticket/2318#comment:20>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system



More information about the Bugs mailing list