#4889 NORM Never A: (activity) fullscreen buttons and (sugar) fullscreen shortcuts fail to get along

[Zarro Boogs per Child]

#4889: (activity) fullscreen buttons and (sugar) fullscreen shortcuts fail to get
along
------------------------------+---------------------------------------------
  Reporter:  Eben             |       Owner:  ApprovalForUpdate
      Type:  defect           |      Status:  new              
  Priority:  normal           |   Milestone:  Never Assigned   
 Component:  browse-activity  |     Version:                   
Resolution:                   |    Keywords:  update.1?        
  Verified:  0                |  
------------------------------+---------------------------------------------
Changes (by erikos):

  * keywords:  update.2? => update.1?
  * owner:  erikos => ApprovalForUpdate
  * component:  sugar => browse-activity


Comment:

 This would be the fix to get the button and the shortcut in sync. Since
 this effects browse this is non invasive and can be verified through
 testing. SO I would like to consider this for update.1

 {{{
 diff --git a/viewtoolbar.py b/viewtoolbar.py
 index 0c3a8d7..2b08360 100644
 --- a/viewtoolbar.py
 +++ b/viewtoolbar.py
 @@ -66,10 +66,7 @@ class ViewToolbar(gtk.Toolbar):
          self._browser.zoom_out()

      def __fullscreen_clicked_cb(self, button):
 -        if self._activity.tray is not None:
 -            self._activity.tray.hide()
 -        if self._activity.toolbox is not None:
 -            self._activity.toolbox.hide()
 +        self._activity.fullscreen()

      def __tray_clicked_cb(self, button):
          if self._activity.tray.props.visible is False:
 }}}

-- 
Ticket URL: <http://dev.laptop.org/ticket/4889#comment:1>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system