#4831 BLOC Update.: Pippy doesn't resume (proximately) because Sugar's datastore.py uses uninitialized variables.

Zarro Boogs per Child bugtracker at laptop.org
Mon Nov 12 16:46:44 EST 2007


#4831: Pippy doesn't resume (proximately) because Sugar's datastore.py uses
uninitialized variables.
---------------------+------------------------------------------------------
 Reporter:  mstone   |       Owner:  marco   
     Type:  defect   |      Status:  new     
 Priority:  blocker  |   Milestone:  Update.1
Component:  sugar    |     Version:          
 Keywords:  review?  |    Verified:  0       
---------------------+------------------------------------------------------
 Trying to resume a Pippy instance in joyride-258 causes the Journal to
 throw an exception on line 125 of sugar/datastore/datastore.py because the
 variable 'parent_type' is used without having been defined.

 The commit which introduced this code, e425c1d8, simply never tested this
 code path (and was not run through pylint, which would have immediately
 revealed the problem.) [Note: pylint gives many warnings about this file,
 which we should review at a later date.]

 The attached patch was tested in-situ and appeared to fix the immediate
 problem. It has not been exhaustively tested for other interactions.

-- 
Ticket URL: <http://dev.laptop.org/ticket/4831>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system



More information about the Bugs mailing list