#2263 HIGH Update.: Colored Icons have dark outline

[Zarro Boogs per Child]

#2263: Colored Icons have dark outline
------------------------------+---------------------------------------------
  Reporter:  bert             |       Owner:  JordanCrouse
      Type:  defect           |      Status:  new         
  Priority:  high             |   Milestone:  Update.1    
 Component:  x window system  |     Version:              
Resolution:                   |    Keywords:              
  Verified:  0                |  
------------------------------+---------------------------------------------

Comment(by bernie):

 This IRC log could be useful:

 <pre>
 <_bernie|home>  marcopg: ah, yesterday CosmicPenguin was asking me about
 the dark outline bug
 <marcopg>       _bernie|home: what's the solution you are proposing for
 debug?
 <_bernie|home>  marcopg: last time we tried, your testacase wouldn't
 reproduce the bug
 <_bernie|home>  marcopg: and oddly, the background is darker than sugar's
 usual background.
 <_bernie|home>  marcopg: almost the same shade that we see in the bug.
 <_bernie|home>  marcopg: does it ring some bell in you?
 <_bernie|home>  marcopg: putting example debug stuff in /etc/skel
 /.xsession-example and let it be installed in /home/olpc by useradd in
 pilgrim
 <_bernie|home>  marcopg: users will just rename the file to enable debug.
 how does it sound?
 <marcopg>       _bernie|home: nope, not really sure what is going on there
 :/
 <marcopg>       _bernie|home: sounds good
 <marcopg>       _bernie|home: we should let testing/sugar/devel ml know
 though, once this is in
 <_bernie|home>  marcopg: how does the XO get superimposed on the
 background? I see that it's just added to an hippocanvas
 <_bernie|home>  marcopg: yes, I should improve the communication... mea
 maxima culpa
 <marcopg>       _bernie|home: it's just a cairo image surface drawn over
 the bg basically
 <_bernie|home>  marcopg: how's the bg done? is it an hippocanvas property
 or it's really being drawn as a rectangle?
 <marcopg>       _bernie|home: how that maps to X calls I'm not sure :)
 <_bernie|home>  the icon is svg and rasterized by hippocanvas itself?
 <marcopg>       _bernie|home: it's an hippo canvas property, but hippo
 draws it as a cairo rectangle likely
 <marcopg>       _bernie|home: nope, sugar rasterize the svg to a cairo
 image surface, and draw it
 <marcopg>       (still using cairo drawing primitives)
 <_bernie|home>  do you think that the XO guy could be "pre-rendered"
 somehow on a different background and then used multiple times later?
 <_bernie|home>  marcopg: aha, how's the bg of this temp surface done?
 <marcopg>       surface = cairo.ImageSurface(cairo.FORMAT_ARGB32, width,
 height)
 <marcopg>       we don't set any background
 <marcopg>       we just draw on that surface
 <_bernie|home>  hmm... maybe the default is #888888?
 <marcopg>       or rather librsvg draws on it
 <_bernie|home>  that would be vey Carl Worth-ish
 <_bernie|home>  marcopg: FORMAT_ARGB32, eh?  maybe we should do
 create_compatible_surface() instead?
 <_bernie|home>  marcopg: the format conversion could be broken or
 something?
 <marcopg>       _bernie|home: yeah, we should avoid format conversions
 there
 <_bernie|home>  (but still it would be a bug in amd_drv if it failed to
 convert correctly)
 <_bernie|home>  I really need to go.. I'm falling asleep
 <marcopg>       the bg is just transparent afaik
 <_bernie|home>  so A=0 and RGB=<don't care> ?
 <marcopg>       I'd guess
 <marcopg>       _bernie|home: almost every icon in sugar goes through that
 code
 <marcopg>       _bernie|home: so I'm pretty sure it's actually transparent
 <_bernie|home>  marcopg: oh, then we should concentrate on what's
 defferent in the XO icon
 <_bernie|home>  marcopg: because it's clearly the only one that gets the
 halo
 <_bernie|home>  marcopg: no, the battery too
 <marcopg>       maybe something in the home drawing code then
 <marcopg>       if you don't see it anywhere else
 <_bernie|home>  marcopg: hint: the other XO icons in the mesh and buddy
 view don't have the halo
 <_bernie|home>  marcopg: I see on the central buddy icon only
 <_bernie|home>  (don't you?)
 <marcopg>       hippo.CanvasBox.__init__(self,
 background_color=0xe2e2e2ff)
 <marcopg>       can you edit HomeBox.py
 <marcopg>       and try to take out the background_color from that line
 <marcopg>       the mesh view doesn't have it
 <_bernie|home>  marcopg: the center of the donut is still ligher
 <_bernie|home>  marcopg: the rest of the home view is darker now
 </pre>

-- 
Ticket URL: <http://dev.laptop.org/ticket/2263#comment:15>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system