#4760 NORM Never A: xulrunner crashes with newer pango

[Zarro Boogs per Child]

#4760: xulrunner crashes with newer pango
------------------------------+---------------------------------------------
  Reporter:  sjoerd           |       Owner:  erikos        
      Type:  defect           |      Status:  new           
  Priority:  normal           |   Milestone:  Never Assigned
 Component:  browse-activity  |     Version:                
Resolution:                   |    Keywords:                
  Verified:  0                |  
------------------------------+---------------------------------------------

Comment(by sjoerd):

 Replying to [comment:1 jg]:
 > I don't understand this patch; it seems to be ifdefing out something....

 It patches out something so it always uses the same code path as with
 older versions of pango.. Judging from the comment in the patch and the
 traceback i saw, the code was enabled because i've got a pango newer then
 1.17.5, but using that code with xulrunners internal snapshot of cairo
 instead of the system cairo causes problrems.

 Anyway the important facts:
   * The XO builds have an older pango, so PANGO_VERSION_CHECK(1,17,5) is
 false on them anyway.
     Meaning that the patch doesn't change anything for them
   * This comes from upstream cvs, who have a better idea of what the issue
 is then me :)
   * It makes browse in jhbuild work again for people with a recent pango.
 So we can actually
     tests it collaboration features again

-- 
Ticket URL: <http://dev.laptop.org/ticket/4760#comment:2>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system