#2466 NORM Untriag: datastore only emits the updated and deleted signals when the object had a file associated

[Zarro Boogs per Child]

#2466: datastore only emits the updated and deleted signals when the object had a
file associated
-----------------------+----------------------------------------------------
 Reporter:  tomeu      |       Owner:  bcsaller 
     Type:  defect     |      Status:  new      
 Priority:  normal     |   Milestone:  Untriaged
Component:  datastore  |     Version:           
 Keywords:             |    Verified:  0        
-----------------------+----------------------------------------------------
 Something like this would emit the signals even if no file is associated
 with the object:

 {{{
 diff --git a/src/olpc/datastore/datastore.py
 b/src/olpc/datastore/datastore.py
 index 111548c..49c33c9 100644
 --- a/src/olpc/datastore/datastore.py
 +++ b/src/olpc/datastore/datastore.py
 @@ -399,9 +399,8 @@ class DataStore(dbus.service.Object):
          content = self.get(uid)
          mountpoint = props.pop('mountpoint', None)
          content.backingstore.update(uid, props, filelike)
 -        if filelike:
 -            self.Updated(content.id)
 -            logger.debug("updated %s" % content.id)
 +        self.Updated(content.id)
 +        logger.debug("updated %s" % content.id)

      @dbus.service.signal(DS_DBUS_INTERFACE, signature="s")
      def Updated(self, uid): pass
 @@ -414,8 +413,8 @@ class DataStore(dbus.service.Object):
          content = self.get(uid)
          if content:
              content.backingstore.delete(uid)
 -            self.Deleted(uid)
 -            logger.debug("deleted %s" % uid)
 +        self.Deleted(uid)
 +        logger.debug("deleted %s" % uid)

      @dbus.service.signal(DS_DBUS_INTERFACE, signature="s")
      def Deleted(self, uid): pass
 }}}

 This is causing the journal not showing an updated view.

-- 
Ticket URL: <https://dev.laptop.org/ticket/2466>
One Laptop Per Child <http://laptop.org/>