[Trac #732] Activities donut should rotate with alt-tab
Zarro Boogs per Child
bugtracker at laptop.org
Wed Jan 17 10:17:21 EST 2007
#732: Activities donut should rotate with alt-tab
-------------------------+--------------------------------------------------
Reporter: ywwg | Owner: ywwg
Type: enhancement | Status: new
Priority: normal | Milestone: BTest-3
Component: sugar | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by ywwg):
Replying to [comment:10 marco]:
> index = [a.get_id() for a in self._activities].index(act_id)
In this case I need the index of the activity, not the activity itself. I
found one place where I can use python's list.remove(x) to replace a list
comprehension (in _internal_remove_activity), but there's one more place
where I must keep it (in _remove_activity).
>
> Factor this out to _get_activity_index(self, activity_id).
> Use it also to implement _get_activity_id
>
{{{
- act = self._activities[act_id]
156 - act.cleanup()
}}}
> Why are you removing this?
I think that's a mistake I made. It's a little confusing because in
activitiesdonut, self._activities is actually a dict of icons, not
activities. Shouldn't it be self._icons?
>
> Looks like you missed this part of my review? Or do you have any issue
with it?
>
> "Can you please split out the draw ring and draw edge parts out to
separate methods?"
I missed this, sorry.
How do I delete an attachment in trac?
--
Ticket URL: <http://dev.laptop.org/ticket/732#comment:11>
One Laptop Per Child <http://laptop.org/>
More information about the Bugs
mailing list