[Trac #559] icons inside activities are not loaded

[Zarro Boogs per Child]

#559: icons inside activities are not loaded
------------------------------+---------------------------------------------
 Reporter:  ywwg              |        Owner:  ywwg   
     Type:  defect            |       Status:  new    
 Priority:  high              |    Milestone:  BTest-3
Component:  interface-design  |   Resolution:         
 Keywords:  sugar-love        |  
------------------------------+---------------------------------------------
Comment (by marco):

 Looks pretty good!

 +        logging.debug("* NOMBRE ICON: "+name)
 +       if name[0:6] == "theme:":

 Either fix up the logging (here and below) or remove them. i.e. use
 english, no caps, no *.

 Are you using spaces? The alignment (see l and i in the above snippet)
 seem screwed. Maybe you are using tabs instead of spaces?

 To follow our style (see the style guide on the wiki) the + and the ,
 should be separated by spaces. For example: "Icon" + name and func(a, b).
 There are a few places in the patch where this should be fixed.

 +            if
 os.path.isfile(os.path.join(os.path.dirname(info_path),self._icon+".svg")):
 +               self._icon =
 os.path.join(os.path.dirname(info_path),self._icon+".svg")
 +           else:

 Please assign os.path.join(os.path.dirname(info_path),self._icon+".svg")
 to a variable before the if, so that we don't repeat the whole thing.

 Please attach the patch as a file, easier for me to commit it. You can
 also just do git diff >patch in the sugar dir.

-- 
Ticket URL: <http://dev.laptop.org/ticket/559#comment:7>
One Laptop Per Child <http://laptop.org/>