#4651 HIGH Update.: Sugar should make better use of tmp space

[Zarro Boogs per Child]

#4651: Sugar should make better use of tmp space
---------------------+------------------------------------------------------
  Reporter:  tomeu   |       Owner:  rwh     
      Type:  defect  |      Status:  new     
  Priority:  high    |   Milestone:  Update.1
 Component:  sugar   |     Version:          
Resolution:          |    Keywords:  review- 
  Verified:  0       |  
---------------------+------------------------------------------------------

Comment(by tomeu):

 {{{
                       self._what_search_combo.append_item(service_name,
 -
 activity_info.name,
 -
 file_name=activity_info.icon)
 +                         activity_info.name)
 }}}

 Don't think we should lose icons in comboboxes. Can we just add an
 optional parameter 'icon_data' to append_item()? We should check that only
 one of icon_name, file_name or icon_data is passed and raise a ValueError
 if that check fails.

 As #5367 has been closed as a duplicate of this, the next version of this
 patch should include the caching of icon data.

-- 
Ticket URL: <http://dev.laptop.org/ticket/4651#comment:19>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system