#3807 LOW Update.: TrayScrollButton not same color as Tray

[Zarro Boogs per Child]

#3807: TrayScrollButton not same color as Tray
---------------------+------------------------------------------------------
  Reporter:  erikb   |       Owner:  marco                            
      Type:  defect  |      Status:  new                              
  Priority:  low     |   Milestone:  Update.1                         
 Component:  sugar   |     Version:  Development build as of this date
Resolution:          |    Keywords:  review-                          
  Verified:  0       |  
---------------------+------------------------------------------------------
Changes (by marco):

  * keywords:  review? => review-


Comment:

 {{{
 +        'can-scroll'      : (bool, None, None, False,
 +                             gobject.PARAM_READABLE),
 +        'can-scroll-prev' : (bool, None, None, False,
 +                             gobject.PARAM_READABLE),
 +        'can-scroll-next' : (bool, None, None, False,
 +                             gobject.PARAM_READABLE),
 }}}

 Maybe we can simplify things by removing can-scroll?

 {{{
 +        # The alignment is a hack to work around gtk.ToolButton code
 +        # that sets the icon_size when the icon_widget is a gtk.Image
 }}}

 Can we just set the toolbar icon size?

 {{{
 +            self.set_sensitive(self._viewport.get_property('can-scroll-
 next')
 }}}

 We are generally using self._viewport.props.can_scroll_next

 {{{
 -        gobject.GObject.__init__(self, **kwargs)
 +        gtk.HBox.__init__(self, **kwargs)
 }}}

 What is the reason of this change? Calling the GObject constructor makes
 gobject properties to work correctly. (there might not be properties in
 that code but still...)

-- 
Ticket URL: <http://dev.laptop.org/ticket/3807#comment:10>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system