#5382 HIGH Update.: sugar/bundle/activitybundle.py uses variables before defining them.

[Zarro Boogs per Child]

#5382: sugar/bundle/activitybundle.py uses variables before defining them.
---------------------+------------------------------------------------------
  Reporter:  mstone  |       Owner:  marco   
      Type:  defect  |      Status:  new     
  Priority:  high    |   Milestone:  Update.1
 Component:  sugar   |     Version:          
Resolution:          |    Keywords:  pylint  
  Verified:  0       |  
---------------------+------------------------------------------------------

Comment(by marco):

 pylint output:

 {{{
 W: 71: FIXME deprecated
 W: 85: FIXME class is deprecated
 W:165: FIXME: this should return the icon data, not a filename, so that
 C:216: Line too long (88/80)
 C:224: Line too long (88/80)
 C:262: Line too long (88/80)
 C:265: Line too long (92/80)
 R: 29:ActivityBundle: Too many instance attributes (8/7)
 C: 63:ActivityBundle._parse_info: Missing docstring
 C: 64:ActivityBundle._parse_info: Invalid name "cp" (should match
 [a-z_][a-z0-9_]{2,30}$)
 R: 63:ActivityBundle._parse_info: Too many branches (14/12)
 C:115:ActivityBundle._get_linfo_file: Missing docstring
 C:132:ActivityBundle._parse_linfo: Missing docstring
 C:133:ActivityBundle._parse_linfo: Invalid name "cp" (should match
 [a-z_][a-z0-9_]{2,30}$)
 E:144:ActivityBundle.get_locale_path: Undefined variable
 'NotInstalledException'
 E:150:ActivityBundle.get_icons_path: Undefined variable
 'NotInstalledException'
 C:201:ActivityBundle.is_installed: Missing docstring
 C:207:ActivityBundle.install: Missing docstring
 E:209:ActivityBundle.install: Undefined variable
 'AlreadyInstalledException'
 E:251:ActivityBundle.install: Undefined variable 'RegistrationException'
 W:275:ActivityBundle.uninstall: Redefining built-in 'file'
 C:253:ActivityBundle.uninstall: Missing docstring
 E:258:ActivityBundle.uninstall: Undefined variable 'NotInstalledException'
 E:284:ActivityBundle.uninstall: Undefined variable 'RegistrationException'
 }}}

-- 
Ticket URL: <http://dev.laptop.org/ticket/5382#comment:1>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system