#3960 NORM Opportu: The shortcut and game keys for Home, End, Page down and Page Up don't affect the journal

[Zarro Boogs per Child]

#3960: The shortcut and game keys for Home,End,Page down and Page Up don't affect
the journal
-------------------------------+--------------------------------------------
  Reporter:  HoboPrimate       |       Owner:  tomeu                            
      Type:  defect            |      Status:  new                              
  Priority:  normal            |   Milestone:  Opportunity                      
 Component:  journal-activity  |     Version:  Development build as of this date
Resolution:                    |    Keywords:  Update.1? review?                
  Verified:  0                 |  
-------------------------------+--------------------------------------------

Comment(by tomeu):

 Replying to [comment:2 rwh]:
 > This patch fixes page up / down and also enable Home and End.

 You are listening for events in the top level window and then calling
 self._list_view._key_press_event_cb(widget, event).

 I would prefer if the callbacks were only called by gtk, never explicitly.

 And in general, private methods and variables (starting with _) should
 only be accessed by the class that immediately contains them. This
 improves the assumptions we can make when reading code. For example, when
 we read the code for the function _initialize_palette(), we can assume
 that this is only called in the local class without having to grep all the
 code base.

 Apart from this code style issue, I think that the only widget that should
 be explicitly listening to those keys should be the list view. The patch
 to listview.py looks good to me.

 > Tomeu: if you have more bugs like this but no time, you can assign them
 to me. I think have a high return on investment; definitely enhances the
 user experience.

 Sure, will do.

-- 
Ticket URL: <http://dev.laptop.org/ticket/3960#comment:3>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system