#5106 HIGH Update.: Attaching a file to gmail msg caused the journal to crash

[Zarro Boogs per Child]

#5106: Attaching a file to gmail msg caused the journal to crash
-------------------------------+--------------------------------------------
  Reporter:  kimquirk          |       Owner:  tomeu   
      Type:  defect            |      Status:  new     
  Priority:  high              |   Milestone:  Update.1
 Component:  journal-activity  |     Version:          
Resolution:                    |    Keywords:  review? 
  Verified:  0                 |  
-------------------------------+--------------------------------------------

Comment(by tomeu):

 Replying to [comment:11 tomeu]:
 > Replying to [comment:10 rwh]:
 > > '''journalactivity.py'''
 > > {{{
 > >     @dbus.service.method(J_DBUS_INTERFACE, in_signature='i',
 out_signature='s')
 > >     def ChooseObject(self, parent_xid):
 > > }}}
 > >
 > > Wouldn't it be nicer design-wise to make this function blocking and
 return the object_id in combination with calling it asynchronously? Maybe
 even a race here because you connect to the DBus signal after calling the
 ChooseObject function. You could connect before and set self._chooser_id
 to None before calling _self.chooser_id = journal.ChooseObject().
 >
 > This makes sense, I'll think a bit more about it.

 The problem I see with that approach is that we would have to call
 ChooseObject async but with a very big timeout, probably of days. And then
 also handle the case where the timeout was passed, perhaps with a suspend
 in the middle.

 I think it's better to remove the race by connecting to the signals before
 calling ChooseObject and filtering there by chooser_id.

-- 
Ticket URL: <http://dev.laptop.org/ticket/5106#comment:12>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system